Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion - update examples to show two html variations #1913

Closed
jgiardino opened this issue Jun 10, 2019 · 1 comment
Closed

Accordion - update examples to show two html variations #1913

jgiardino opened this issue Jun 10, 2019 · 1 comment
Assignees
Milestone

Comments

@jgiardino
Copy link
Contributor

Here are a few examples of accordions out there:
https://www.w3.org/TR/wai-aria-practices-1.1/#accordion
https://inclusive-components.design/collapsible-sections/
https://www.scottohara.me/blog/2017/10/25/accordion-release.html
https://a11yproject.com/patterns/

The first 3 use headings, without a definition list. The last link includes an example, "Simple Accordion", that uses a definition list and not headings.

Our pattern uses both, which isn't considered valid html. Instead, we should support one or the other. Our core css currently supports not including a heading, but it doesn't support not using the <dl> elements.

Updates needed for this issue:

  • Update the examples shown to use either headings or definition list
  • Include an extra example showing the other variation
  • Make sure the css gets applied to both variations as expected
  • Create an issue in react to make similar updates when this issue closes
@patternfly-build
Copy link

🎉 This issue has been resolved in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants