Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core updates: Toolbar and Action List #9677

Closed
Tracked by #152
, #9413
...
andrew-ronaldson opened this issue Sep 26, 2023 · 2 comments · Fixed by #10041
Closed
Tracked by #152
, #9413
...

Consume core updates: Toolbar and Action List #9677

andrew-ronaldson opened this issue Sep 26, 2023 · 2 comments · Fixed by #10041
Assignees
@thatblindgeye
Milestone
Penta alpha release

Comments

@andrew-ronaldson
Copy link
Collaborator

andrew-ronaldson commented Sep 26, 2023 •
edited by tlabaj
Loading

Follow up to Core Toolbar issue

in core bump PR #10022 he following was done:

  • removed application of pf-m-chip-container modifier on toolbar group in ToolbarExpandableContent.tsx
  • removed application of pf-m-buttonGroup modifier on toolbar group in
  • removed import of @patternfly/react-tokens/dist/esm/c_toolbar__item_Width since it no longer exists. also comment out widths prop application since it depends on the token.
  • Removed bulkSelect, overflowMenu, searchFilter modifier applications on toolbar item
This was referenced Sep 26, 2023
Closed
Closed
@andrew-ronaldson andrew-ronaldson added this to the 2023.Q4 milestone Sep 26, 2023
@andrew-ronaldson andrew-ronaldson changed the title Consume core updates: Toolbar and Action List ( Follow up to issue) Consume core updates: Toolbar and Action List Sep 26, 2023
@stale Stale
Copy link

stale bot commented Nov 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 25, 2023
@andrew-ronaldson andrew-ronaldson modified the milestones: 2023.Q4, 2024.Q1 Nov 27, 2023
@stale stale bot closed this as completed Dec 12, 2023
@stale stale bot closed this as completed Dec 31, 2023
@evwilkin evwilkin removed the wontfix label Jan 4, 2024
@evwilkin evwilkin reopened this Jan 4, 2024
@tlabaj tlabaj mentioned this issue Jan 22, 2024
Merged
@thatblindgeye thatblindgeye self-assigned this Jan 23, 2024
This was referenced Jan 24, 2024
Merged
Merged
@thatblindgeye thatblindgeye linked a pull request Jan 29, 2024 that will close this issue
feat(ActionList): consumed Penta updates #10041
Merged
@thatblindgeye
Copy link
Contributor

Closed by #10041 and #10042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(ActionList): consumed Penta updates thatblindgeye/patternfly-react
5 participants
@wise-king-sullyman @evwilkin @andrew-ronaldson @tlabaj @thatblindgeye