feat(Toolbar): consumed Penta updates #10042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10042.surge.sh A11y report: https://patternfly-react-pr-10042-a11y.surge.sh |
@thatblindgeye good to delete! |
thatblindgeye
requested review from
mattnolting,
a team,
wise-king-sullyman,
kmcfaul,
andrew-ronaldson and
lboehling
and removed request for
a team
wise-king-sullyman
approved these changes
Jan 26, 2024
|
Great work @thatblindgeye, thank you! |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
|
|
|
This react demo also cuts off the content. Doesn't do that on current site.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Towards #9677
@mattnolting Based on updates in Core, we removed some modifier classes/props in React. The
pf-m-chip-containerclass no longer has any styles in Core so was removed in React, but Core is still applying the class. Do we want to keep this modifier class or should it be removed in Core?Additional issues: