feat(Icon): add new icon sizes for penta #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10030.surge.sh A11y report: https://patternfly-react-pr-10030-a11y.surge.sh |
wise-king-sullyman
requested review from
a team,
mfrances17,
kmcfaul,
andrew-ronaldson,
lboehling and
srambach
and removed request for
a team
thatblindgeye
approved these changes
Jan 26, 2024
| @@ -41,16 +42,34 @@ test('sets additional custom class successfully', () => { | |||
| expect(iconContainer).toHaveClass('test'); | |||
| }); | |||
|
|
|||
| Object.values(['sm', 'md', 'lg', 'xl']).forEach((size) => { | |||
| Object.values([ | |||
There was a problem hiding this comment.
Nit: could we instead combine the 3 instances of this forEach into a single one, then just run all the tests that need to in here
andrew-ronaldson
approved these changes
Jan 29, 2024
gitdallas
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9988
Additional issues:
I added the
case-anythingpackage to handle changing case (i.e. cameCase to kebab-case) for us, needed it for converting prop values to class names in the updated Icon tests.Convenience link: https://patternfly-react-pr-10030.surge.sh/components/icon/