V6 rebase #10033
Merged
V6 rebase #10033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* fix(Text input): Added aria-expanded * add interface * updates from review
…rawer item read state (patternfly#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots
…y#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file
* chore(Divider): update tests to new standards * changes from PR review
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…es (patternfly#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - [email protected]
…lease.4 (patternfly#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
…ly#9048 (patternfly#9087) * feat(Datalist): implement full page Basic demo to match HTML patternfly#9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lease.5 (patternfly#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* clean up instances of Array.apply * rename item to value
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change
* bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <[email protected]> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <[email protected]> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…y#9941) * FileUploadField name attribute fix * update snapshots * prevent breaking change --------- Co-authored-by: nicolethoen <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(charts): Victory dependency update Closes patternfly#9960 * chore(charts): update lodash dependency
- @patternfly/[email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected]
|
Preview: https://patternfly-react-pr-10033.surge.sh A11y report: https://patternfly-react-pr-10033-a11y.surge.sh |
thatblindgeye
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
My updates from main look good, Accordion is working well with both main + v6 updates I had made.
Am noticing that in dark theme the accordion toggle's hover styling is no longer working/the same as when the core PR went in. @lboehling was there an update made to either the --pf-t--global--background--color--action--plain--default or --pf-t--global--background--color--action--plain--hover tokens recently? When I build the core repo locally I'm also noticing that the background color isn't changing on hover in dark theme on the accordion toggle, but in the original core PR it's working fine.
@thatblindgeye no, there haven't been any updates made to those tokens recently as far as i know. Is the mix blend mode token being added to the hover state? I'm also noticing that the expanded state bkg looks different from the original core PR too. |
wise-king-sullyman
approved these changes
Jan 24, 2024
kmcfaul
approved these changes
Jan 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10032
Additional issues: