feat(Tabs): consumed Penta updates #10044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10044.surge.sh A11y report: https://patternfly-react-pr-10044-a11y.surge.sh |
thatblindgeye
requested review from
a team,
nicolethoen,
mfrances17,
andrew-ronaldson,
lboehling and
mattnolting
and removed request for
a team
This was
linked to
issues
Jan 29, 2024
nicolethoen
approved these changes
Jan 30, 2024
andrew-ronaldson
approved these changes
Jan 30, 2024
thatblindgeye
force-pushed
the
tabsPenta
branch
from
715dfce
to
fbd162d
Compare
wise-king-sullyman
approved these changes
Jan 31, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10043, closes #9909
Codemod for tabs
Preview for tabs
As an FYI this PR suffers (may suffer depending on whether it affects you) the same visual bug mentioned in the original Core PR, which that will require a followup.
This also bumps the core alphas as they're needed for this update.
Per convo with design during one of the Penta meetings, it was decided that the
secondarystyling for TabContent should only be enabled when the Tabs component has bothpf-m-boxandpf-m-secondary, as the background colors of the current tab and the tab content will match as intended. Consumers can still use a non-box Tabs with secondary TabContent styling, though. If we'd want to restrict that a bit more we could consider removing theisBoxprop and update thevariantprop to accept default, box, and box-secondary values.Additional issues: