Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TextArea): Convert TextArea to typescript #2168

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jun 5, 2019

#1953

What:

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2168-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #2168 into master will decrease coverage by 0.18%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   80.84%   80.66%   -0.19%     
==========================================
  Files         651      661      +10     
  Lines        8260     8327      +67     
  Branches      628      631       +3     
==========================================
+ Hits         6678     6717      +39     
- Misses       1282     1309      +27     
- Partials      300      301       +1
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.18% <93.75%> (-0.3%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/TextArea/index.ts 100% <100%> (ø)
...-4/react-core/src/components/TextArea/TextArea.tsx 93.33% <93.33%> (ø)
...atternfly-4/react-core/src/components/Page/Page.js 47.61% <0%> (-6.55%) ⬇️
...s/patternfly-4/react-core/src/layouts/Grid/Grid.js 93.33% <0%> (-1.12%) ⬇️
...ct-core/src/components/Pagination/OptionsToggle.js 83.33% <0%> (ø) ⬆️
...y-3/patternfly-react/src/components/Label/Label.js 100% <0%> (ø) ⬆️
...y-4/react-core/src/components/Progress/Progress.js 100% <0%> (ø) ⬆️
...4/react-core/src/components/Accordion/Accordion.js 100% <0%> (ø) ⬆️
...fly-3/patternfly-react/src/components/Form/Form.js 100% <0%> (ø) ⬆️
...y-3/patternfly-react/src/components/Alert/Alert.js 100% <0%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3da9a...8b228ec. Read the comment docs.

@patternfly patternfly deleted a comment from redallen Jun 7, 2019
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen redallen merged commit 9be5c0b into patternfly:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants