Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-table): Some props of IRow should not required #2196

Merged
merged 1 commit into from
Jun 10, 2019
Merged

fix(react-table): Some props of IRow should not required #2196

merged 1 commit into from
Jun 10, 2019

Conversation

kunyan
Copy link
Contributor

@kunyan kunyan commented Jun 10, 2019

What:

Makes following props of IRow to optional

  • isOpen
  • parent
  • props

patternfly-react/packages/patternfly-4/react-table/src/components/Table/Table.js

Line 183 in 979f13f

rows.every(row => this.isSelected(row) || (row.hasOwnProperty('parent') && !row.showSelect));

The parent props should not define anything to pass the check

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2196-pr-patternfly-react-patternfly.surge.sh

@kunyan kunyan mentioned this pull request Jun 10, 2019
Closed
@redallen redallen merged commit 343f928 into patternfly:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redallen redallen redallen approved these changes

@priley86 priley86 priley86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kunyan @patternfly-build @priley86 @redallen