-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF4 - use context api in page component #2208
Conversation
PatternFly-React preview: https://2208-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
=========================================
Coverage ? 80.27%
=========================================
Files ? 658
Lines ? 8252
Branches ? 643
=========================================
Hits ? 6624
Misses ? 1326
Partials ? 302
Continue to review full report at Codecov.
|
)} | ||
</div> | ||
)} | ||
{/* Hide for now until we have the context selector component */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have . context Selector. Why are we hiding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been here since before the context selector got created. Perhaps we should update the page component now to support it? Should be in a separate PR though. @rachael-phillips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. We should do tis in a separate PR. @rachael-phillips I opened a separate issue (#2285) to track that work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix merge conflicts and I'll reapprove!
PatternFly-React preview: https://patternfly-react-pr-2208.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #2188