Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table type adjustments #2248

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

seanforyou23
Copy link
Collaborator

What: This PR updates the type used in react-table to be a little more explicit. Also updates the example code in the readme, following along as-is in a TypeScript application leads to the following error

Screen Shot 2019-06-12 at 10 52 42 AM

I took a stab at using better types for transforms, what do people think about this new type? I'd like to use something more specific than Array<Function> if possible as this doesn't inform of what the inputs and outputs should or can be. Might be good to wait until this is converted fully to TS to address the others, but I'm curious what others think.

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2248-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #2248 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2248      +/-   ##
==========================================
- Coverage   79.89%   79.88%   -0.01%     
==========================================
  Files         669      668       -1     
  Lines        8529     8520       -9     
  Branches      734      731       -3     
==========================================
- Hits         6814     6806       -8     
  Misses       1362     1362              
+ Partials      353      352       -1
Flag Coverage Δ
#patternfly3 85.23% <ø> (ø) ⬆️
#patternfly4 74.89% <ø> (-0.03%) ⬇️
#patternflymisc 95.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...src/components/Pagination/PaginationOptionsMenu.js 92.3% <0%> (-0.55%) ⬇️
...ernfly-4/react-core/src/components/Alert/Alert.tsx 88% <0%> (-0.47%) ⬇️
...ts/src/components/ChartTheme/themes/label-theme.ts
...ct-core/src/components/Pagination/OptionsToggle.js 83.33% <0%> (+3.33%) ⬆️
...ct-charts/src/components/ChartLabel/ChartLabel.tsx 100% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4e100...047c5cc. Read the comment docs.

@priley86
Copy link
Member

No issues from me and thanks for taking time to look into this. I think any good improvements on this will be helpful for #1950 later. 👍

Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your approach with providing further information to anyone implementing new ransform function! We should also help consumers with cellTransforms, columnTransforms and formatters because these are essentatially the same bu effect different part of table.

karelhala
karelhala previously approved these changes Jun 13, 2019
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! Thank you.

Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thank you.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 7b6468c into patternfly:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants