fix(react-table): Add exports for compoundExpand. #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcaianirh
changed the title
|
PatternFly-React preview: https://patternfly-react-pr-2554.surge.sh |
priley86
approved these changes
Jul 22, 2019
redallen
approved these changes
Jul 22, 2019
| @@ -19,5 +19,5 @@ export { default as TableHeader, HeaderProps } from './Header'; | |||
| export { default as TableBody, TableBodyProps } from './Body'; | |||
| export { default as RowWrapper, RowWrapperRow, RowWrapperProps } from './RowWrapper'; | |||
| export { default as ExpandableRowContent } from './ExpandableRowContent'; | |||
| export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded } from './utils'; | |||
| export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded, compoundExpand } from './utils'; | |||
There was a problem hiding this comment.
This seems close to export * from './utils';
Either way, the TS conversion in #2360 will eventually resolve this too.
There was a problem hiding this comment.
+1... i am planning to circle back and ensure we can do export * on all exports, and that they are converted from default exports to named exports... will probably attempt this towards the end to be certain. I've gone ahead and rebased this change for now though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix for issue: #1657
Additional issues:
Add exports for compoundExpand.