Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codeeditor): allow passing options and overrideServices #6035

Merged
merged 1 commit into from
Jul 15, 2021
Merged

feat(codeeditor): allow passing options and overrideServices #6035

merged 1 commit into from
Jul 15, 2021

Conversation

redallen
Copy link
Contributor

What: Towards #2543

Additional issues:

@redallen redallen changed the title allow passing options and overrideServices feat(codeeditor): allow passing options and overrideServices Jul 15, 2021
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 15, 2021 •
edited
Loading

PF4 preview: https://patternfly-react-pr-6035.surge.sh
A11y report: https://patternfly-react-pr-6035-a11y.surge.sh

@redallen redallen mentioned this pull request Jul 15, 2021
Merged
@redallen redallen requested a review from kmcfaul July 15, 2021 17:35
nicolethoen
nicolethoen approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had looked at this, but needed to wait until it finished building - then i forgot to come back to it ;)

@nicolethoen nicolethoen merged commit 6017c94 into patternfly:main Jul 15, 2021
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@jschuler jschuler jschuler approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redallen @patternfly-build @jschuler @nicolethoen