Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds content to alert group react examples. #7763
Adds content to alert group react examples. #7763
Changes from 4 commits
aa9b84a
f85dfb4
9124b80
ed4e5ac
dfbcd57
0ba6680
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or something along those lines. Based on @mcarrano comment above about that async example, adding some verbiage about that here may not be bad. Part of the intent is also to help differentiate when one would want to use a toast alert group since it and the normal dynamic group are fairly similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a tweak here, to combine some verbiage you had elsewhere and bring it up here to a less specific section:
Or something along those lines. Basically the goals I had with this tweak is to make it clear you must pass in
isLiveRegion
to the alert group when alerts will be dynamic, and to link to the a11y docs for aria-atomic/aria-relevant (which was originally mentioned further down).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor tweaks here, based on the suggestion I made a bit further down at #7763 (comment)