-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds content to select component examples. #8399
Conversation
Preview: https://patternfly-react-pr-8399.surge.sh A11y report: https://patternfly-react-pr-8399-a11y.surge.sh |
I wouldn't be shocked if there's a typo causing this issue -- I'll look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edonehoo importing SelectVariant
into the examples below should hopefully fix your build issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! Some of my comments below include possibly changing the order of examples, so let me know what you think!
Thanks, @thatblindgeye! Any ideas re: the build failing? Also @nicolethoen @evwilkin EDIT: nvm just saw Eric's comment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! In addition to comments above, just had one more below
Does it make sense to change "custom filtering" to "typeahead with custom filtering"? I know the focus of the example is on the filtering part, but it's also a typeahead example, so I added "typeahead" to mirror the other examples. Can't decide if that makes the example more or less unclear. In general - are any titles too wordy? How does the ordering look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to change "custom filtering" to "typeahead with custom filtering"? I know the focus of the example is on the filtering part, but it's also a typeahead example, so I added "typeahead" to mirror the other examples. Can't decide if that makes the example more or less unclear.
In general - are any titles too wordy? How does the ordering look now?
Considering the other examples in that section have "Typeahead..." before it, I think it would make sense to add that to the custom filtering example.
Since we can't currently have subsections under that "Examples" heading without breaking the build, I think the titles as they are fine. Some possible alternatives are below, but they aren't blockers to me and would be interested in what others think.
7ba50da
to
ce36aa4
Compare
11e44db
to
26b865b
Compare
Your changes have been released in:
Thanks for your contribution! 🎉 |
Makes progress on patternfly/patternfly-org#2990