Do not quote file paths passed to mailcap entries #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. |
The readme.md example itself uses double-quotes but tg still shell-escapes/quotes filepaths. Specifically, mailcap entries like video/*; mpv --quiet --loop=inf '%s'; test=test -n "$DISPLAY" would be passed quoted strings for `%s' and create bogus commands like mpv --quiet ''/path with space.mp4'' effectively breaking the quotes. Leave all quoting to mailcap entries and pass file paths unaltered to prevent this. NB: This is only a best-effort approach, i.e. file paths are still shell-escaped in tg's Python code and then passed to NOTIFY_CMD et al. expecting them to be interpreted by the shell. It would be best to either - pass literal file paths and message/title/etc. strings to external commands such that they handle them (possibly being executed directly without SHELL), or - handle and format the entire command incl. its arguments in tg such that correct escaping can be ensured.
|
You're right. I've updated my commit to only avoid quoting for mailcap handled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme.md example itself uses double-quotes but tg still
shell-escapes/quotes filepaths.
Specifically, mailcap entries like
video/*; mpv --quiet --loop=inf '%s'; test=test -n "$DISPLAY"
would be passed quoted strings for `%s' and create bogus commands like
mpv --quiet ''/path with space.mp4''
effectively breaking the quotes.
NB: This is only a best-effort approach, i.e. file paths are still
shell-escaped in tg's Python code and then passed to NOTIFY_CMD et al.
expecting them to be interpreted by the shell.
It would be best to either
commands such that they handle them (possibly being executed directly
without SHELL), or
that correct escaping can be ensured.