Release v0.5.0 #21
Merged
Release v0.5.0 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) add support for adding attribute values passed via a hash
2) add testcases for it
1) refactor #attribute_values_to_hash
2) rewrite comment
One of the Java method of Instances has unexpected behavior.
enumerateAttributes will skip the class attribute once it is
set. Therfore we have to manually add the class attribute,
otherwise we we will miss it in every method that calls
Instances#attributes.
See also:
http://weka.sourceforge.net/doc.stable/weka/core/Instances.html#enumerateAttributes--
1) The previous fix only works when class attribute is the last
attribute. The bug fix address that problem.
2) use attribute in the middle as the class attribute for the
test cases in the spec.
1) use keyword argument for #attributes and #attribute_names
2) fix #ensure_attribute_defined! and #attribute_with_name
3) refactor private methods #attribute_values_to_hash and
#attribute_values_from_hash
4) add new test cases and refactor the spec
Feature: allow passing hash to Instances#add_instance
Cleanup core/instances spec
to_m returns a Matrix object holding all instances's values as rows.
Add to_m to Core::Instances
…odule Add curve classes to classifier evaluator namespace
This splits up the different method groups into separate modules and makes it a bit more readable and changeable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See release notes.