handle v7 #31
handle v7 #31
Conversation
| @@ -49,6 +49,11 @@ function makeScoringGuide(curves) { | |||
| } | |||
|
|
|||
| export const scoringGuides = { | |||
| // v7 scoring is identical to v6 | |||
| v7: { | |||
There was a problem hiding this comment.
given the version collapsing, this bit isn't necessary, but it feels good for anyone else consuming this code.
script/main.js
Outdated
| render() { | ||
| const {versions, device, metricValues} = this.state; | ||
|
|
||
| this.collapseVersions(versions); |
There was a problem hiding this comment.
Does this have to mutate state? Can it return a new array and be used on L281?
There was a problem hiding this comment.
ill let you take another look as i changed things quite a bit.
Co-authored-by: Connor Clark <[email protected]>
script/main.js
Outdated
| @@ -178,7 +178,7 @@ class ScoringGuide extends Component { | |||
|
|
|||
| let title = <h2>{name}</h2>; | |||
| if (name === 'v6') { | |||
| title = <h2><a href="https://github.com/GoogleChrome/lighthouse/releases/tag/v6.0.0" target="_blank">v6</a></h2>; | |||
| title = <h2>latest<br/><i>v6, v7</i></h2>; | |||
There was a problem hiding this comment.
could just link to the releases page?
| throw new Error(`Unsupported Lighthouse version (${version})`); | ||
| } | ||
| // In the future we might want a more generalized `version % 2 === 1` thing, but for now, hardcode the change. | ||
| if (parseInt(version) === 7) return 6..toString(); |
There was a problem hiding this comment.
hello ruby my old friend
There was a problem hiding this comment.
😀 not range operator. it's just how you call methods on a number literal.
one could do 123.45.toLocaleString() but if you're calling on an integer, you'll need two periods: 123..toLocaleString(). (If you try 123.toLocaleString(), you'll get a SyntaxError.
i dont remember where i picked this up, but it's some esoteric JS knowledge that's been tucked away in my brain. :p
| // In the future we might want a more generalized `version % 2 === 1` thing, but for now, hardcode the change. | ||
| if (parseInt(version) === 7) return 6..toString(); | ||
| return version.toString(); | ||
| }).sort().reverse(); |
There was a problem hiding this comment.
default sort sorts as strings...idk problem for future us or wanna knock it out now?
There was a problem hiding this comment.
shouldnt matter tbh. leaving for later if it ever does matter :)
#FCP=671&SI=671&LCP=762&TTI=671&TBT=0&CLS=0&FCI=671&FMP=671&device=mobile&version=7.0.0