Fix for review comment

paullouisageneau · Aug 31, 2023 · 43c9ea3 · 43c9ea3
1 parent 3ab9d06
commit 43c9ea3
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 11 deletions.
diff --git a/include/rtc/h264rtppacketizer.hpp b/include/rtc/h264rtppacketizer.hpp
@@ -23,11 +23,13 @@ class RTC_CPP_EXPORT H264RtpPacketizer final : public RtpPacketizer,
 	shared_ptr<NalUnits> splitMessage(binary_ptr message);
 	const uint16_t maximumFragmentSize;
 
+using Separator=NalUnit::Separator;
+
 public:
 	/// Default clock rate for H264 in RTP
 	inline static const uint32_t defaultClockRate = 90 * 1000;
 
-	H264RtpPacketizer(NalUnit::Separator separator,
+	H264RtpPacketizer(Separator separator,
 	                  shared_ptr<RtpPacketizationConfig> rtpConfig,
 	                  uint16_t maximumFragmentSize = NalUnits::defaultMaximumFragmentSize);
 
@@ -43,7 +45,7 @@ class RTC_CPP_EXPORT H264RtpPacketizer final : public RtpPacketizer,
 	                                                    message_ptr control) override;
 
 private:
-	const NalUnit::Separator separator;
+	const Separator separator;
 };
 
 } // namespace rtc

diff --git a/include/rtc/h265nalunit.hpp b/include/rtc/h265nalunit.hpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/include/rtc/h265packetizationhandler.hpp b/include/rtc/h265packetizationhandler.hpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/include/rtc/h265rtppacketizer.hpp b/include/rtc/h265rtppacketizer.hpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/h264rtppacketizer.cpp b/src/h264rtppacketizer.cpp
@@ -24,7 +24,7 @@ namespace rtc {
 
 shared_ptr<NalUnits> H264RtpPacketizer::splitMessage(binary_ptr message) {
 	auto nalus = std::make_shared<NalUnits>();
-	if (separator == NalUnit::Separator::Length) {
+	if (separator == Separator::Length) {
 		size_t index = 0;
 		while (index < message->size()) {
 			assert(index + 4 < message->size());
@@ -83,9 +83,9 @@ shared_ptr<NalUnits> H264RtpPacketizer::splitMessage(binary_ptr message) {
 H264RtpPacketizer::H264RtpPacketizer(shared_ptr<RtpPacketizationConfig> rtpConfig,
                                      uint16_t maximumFragmentSize)
     : RtpPacketizer(rtpConfig), MediaHandlerRootElement(), maximumFragmentSize(maximumFragmentSize),
-      separator(NalUnit::Separator::Length) {}
+      separator(Separator::Length) {}
 
-H264RtpPacketizer::H264RtpPacketizer(NalUnit::Separator separator,
+H264RtpPacketizer::H264RtpPacketizer(Separator separator,
                                      shared_ptr<RtpPacketizationConfig> rtpConfig,
                                      uint16_t maximumFragmentSize)
     : RtpPacketizer(rtpConfig), MediaHandlerRootElement(), maximumFragmentSize(maximumFragmentSize),

diff --git a/src/h265nalunit.cpp b/src/h265nalunit.cpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/h265packetizationhandler.cpp b/src/h265packetizationhandler.cpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this

diff --git a/src/h265rtppacketizer.cpp b/src/h265rtppacketizer.cpp
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020 Filip Klembara (in2core)
+ * Copyright (c) 2023 Zita Liao (Dolby)
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this