Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H.265 packetizer and related codec selection #932

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

ZitaLiao
Copy link
Contributor

No description provided.

@ZitaLiao ZitaLiao changed the title [for review]: add H.265 Packetizer and related codec selection in WebRTC support [for early review]: add H.265 Packetizer and related codec selection in WebRTC support Jul 20, 2023
@murillo128
Copy link

This PR adds H265 packetization according to RFC 7798 RTP Payload Format Implementation. Our plan is to integrate in OBS so it can be used with the nvenc h265 encoder which provides awesome quality.

We are testing/validating the PR with the fixed H265 support Safari as per WebKit/WebKit#15494

@paullouisageneau could you review this and provide us feedback of any change that may be required for merging?

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you for the contribution! I've just a few comments about duplicated code which could be made common with the h264 packetizer.

include/rtc/h265packetizationhandler.hpp Show resolved Hide resolved
include/rtc/h265rtppacketizer.hpp Outdated Show resolved Hide resolved
src/h265rtppacketizer.cpp Outdated Show resolved Hide resolved
@ZitaLiao ZitaLiao changed the title [for early review]: add H.265 Packetizer and related codec selection in WebRTC support add H.265 Packetizer and related codec selection in WebRTC support Aug 21, 2023
@ZitaLiao
Copy link
Contributor Author

@paullouisageneau Thank you for the review!
I rebased today and fixed per your comment. Could you please help to review again? Thank you in advanced.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, it looks good overall. Don't worry about #929, I'll add this to the refactoring.

include/rtc/h264rtppacketizer.hpp Show resolved Hide resolved
include/rtc/h265nalunit.hpp Outdated Show resolved Hide resolved
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paullouisageneau paullouisageneau changed the title add H.265 Packetizer and related codec selection in WebRTC support Add H.265 packetizer and related codec selection Aug 31, 2023
@paullouisageneau paullouisageneau merged commit a84ea79 into paullouisageneau:master Aug 31, 2023
11 checks passed
paullouisageneau added a commit that referenced this pull request Sep 5, 2023
…rivate-separator

Fix H264RtpPacketizer::Separator made private by #932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants