Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always return promise in close() #1359

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: always return promise in close() #1359

merged 1 commit into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. fix: always return promise in close() 

    Updates the `close` method to always return a `Promise` rather than
having a mixed return type.

We do not need to check `closed` since we only care if the close
logic/promise has already started, so switching the condition should be
enough.
    @43081j
    43081j committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    34f4271 View commit details
    Browse the repository at this point in the history