-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dust Outputs #107
Comments
@Polybius93 it looks like this library uses a dust limit of 148, and so that TXO of value 210 isn't considered dust by scure. Line 333 in 9a29c88
When adding outputs to the transaction, scure will add a change output if the value of the change exceeds 148. Line 565 in 9a29c88
@paulmillr I believe this is a bug. The line in core referenced by the code comment (link) describes a byte size of 148, not a dust limit in sats.
The actual dust limit that a node uses for its mempool relaying policy is defined by the minimum fee needed to spend an output at a particular (configurable) fee rate called the
If you're looking to hardcode a single number you can use to cover most use cases, i suppose 546 should suffice (see comment above for the math). @Polybius93 Regarding your specific case, you should be able to fix your problem by passing the Lines 346 to 354 in 9a29c88
This allows you to override the dust threshold of |
Let me know of main branch works @Polybius93 or if you need help with building of the main branch. @conduition I think it's fixed now |
Hey @paulmillr , thank you for the quick fix, it did work, when can we expect it to be released? Thank you! |
@paulmillr Thanks for the quick response, but I think you may need to reconsider the fix: d1bc93d#r145217554 |
I opened a PR with some improved dust fixes here: #109 |
The selectUTXO function produces occasionally
dust
outputs.This is how I use the selectUTXO function:
Here is the UTXO being used:
And after selectUTXO, this transaction is created:
Is there a way to avoid this, or I have to check if any of the transaction's output is under the dust limit?
Thank you very much!
@paulmillr
The text was updated successfully, but these errors were encountered: