Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Add support for dashed arguments #49

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Add support for dashed arguments #49

merged 1 commit into from
Apr 21, 2017

Conversation

bmcallis
Copy link
Contributor

Like a lot of node modules, I'd like to be able to pass dashed arguments like --skip-tests to my runjs tasks. This PR allows that.

@bmcallis bmcallis mentioned this pull request Apr 10, 2017
Closed
nmschulte
nmschulte approved these changes Apr 20, 2017
View reviewed changes
Copy link

@nmschulte nmschulte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great; I like the inclusion of the - and the .; though really, it would be best if the parsing operated around whitespace (tokenization) instead of matching a "whitelist of allowable chars."

pawelgalazka
pawelgalazka approved these changes Apr 21, 2017
View reviewed changes
Copy link
Owner

@pawelgalazka pawelgalazka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Merging...

@pawelgalazka pawelgalazka merged commit 9758da7 into pawelgalazka:master Apr 21, 2017
@pawelgalazka
Copy link
Owner

Changes published to npm under 3.2.1 version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmschulte nmschulte nmschulte approved these changes

@pawelgalazka pawelgalazka pawelgalazka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmcallis @pawelgalazka @nmschulte