Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Finding Cleanup #6

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Audit Finding Cleanup #6

merged 1 commit into from
Nov 12, 2024

Conversation

zpetersen-paxos
Copy link
Collaborator

This PR addresses a couple of audit finding follow ups:

  • Adds missing has_one constraints
  • Remove unit test doesn't test any error generated by the Paxos contract (it's throwing a JavaScript error). This can be safely removed as an empty pending_admin can't be accepted.

@zpetersen-paxos zpetersen-paxos merged commit b1ba5cc into master Nov 12, 2024
1 check passed
@zpetersen-paxos zpetersen-paxos deleted the audit-finding-followup branch November 12, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmtorres jacobmtorres jacobmtorres approved these changes

@biokrylov biokrylov biokrylov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zpetersen-paxos @biokrylov @jacobmtorres