This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Use restCall object for functions that makes requests #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypatel512
suggested changes
May 8, 2017
There was a problem hiding this comment.
Thank you so much @rusan for your PR. Really appreciated. I have one or two very minor things that we could do, to make it into an awesome PR. 👍
lib/PayPal/Api/FuturePayment.php
Outdated
| @@ -20,7 +20,7 @@ class FuturePayment extends Payment | |||
| * @param string|null $clientMetadataId | |||
| * @return $this | |||
| */ | |||
| public function create($apiContext = null, $clientMetadataId = null) | |||
| public function create($apiContext = null, $clientMetadataId = null, $call = null) | |||
There was a problem hiding this comment.
Can we please name this $restCall too, just for consistency.
lib/PayPal/Api/FuturePayment.php
Outdated
| @@ -32,7 +32,7 @@ public function create($apiContext = null, $clientMetadataId = null) | |||
| ); | |||
| } | |||
| $payLoad = $this->toJSON(); | |||
| $call = new PayPalRestCall($apiContext); | |||
| $call = $call ? $call : new PayPalRestCall($apiContext); | |||
There was a problem hiding this comment.
Curious, if we could just replace this with executeCall itself. Maybe we can do that as a separate PR.
|
@jaypatel512 - Done. |
|
You are awesome @rusan ! We will do a quick test on this PR, and merge it soon. Thank you again for your contribution. 🎆 |
jaypatel512
approved these changes
May 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.