This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
Added createOptions scriptLocation #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a create option where the script, which contains __REACT_ENGINE__, can be added to the head of the html. Ideally I would like an option to not automatically render the script tag automatically plus a function to generate the script which allows me to put it where I want in the html component manually, but this works for now.
--- Usage ---
const engine = reactEngine.server.create({
routes: require('./routes.jsx'),
routesFilePath: './routes.jsx',
scriptLoc: 'head',
page404: require('./not-found.jsx'))
})
|
Would you mind updating the readme |
|
@vuhwang I will get that changed to |
…mentation. Option name scriptLoc changed to scriptLocation.
JustinMGaiam
changed the title
|
@vuhwang ok the scriptLocation changes have been made |
|
thanks @JustinMGaiam. v3.3.0 has been published with this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a create option where the script, which contains REACT_ENGINE, can be added to the head of the html. Ideally I would like an option to not automatically render the script tag automatically plus a function to generate the script which allows me to put it where I want in the html component manually, but this works for now.
--- Usage ---
const engine = reactEngine.server.create({
routes: require('./routes.jsx'),
routesFilePath: './routes.jsx',
scriptLocation: 'head',
page404: require('./not-found.jsx'))
})