Fix lint issues in util

[nickajacks1]

Also reduce execution time of ConvertComponentIdIntoFriendlyPathSearch by 50-60% and add benchmark

Lint issues fixed:

utils/utils.go:567:22: S1007: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (gosimple)
var bracketNameExp = regexp.MustCompile("^(\\w+)\\[(\\w+)\\]$")
                     ^
utils/utils_test.go:232:28: S1040: type assertion to the same type: parsed already has type interface{} (gosimple)
        assert.Equal(t, "niblet", parsed.(interface{}))
                                  ^
utils/utils_test.go:171:2: S1021: should merge variable declaration with assignment on next line (gosimple)
        var d interface{}
        ^
utils/utils_test.go:198:2: S1021: should merge variable declaration with assignment on next line (gosimple)
        var d interface{}
        ^
utils/utils_test.go:236:2: S1021: should merge variable declaration with assignment on next line (gosimple)
        var d interface{}
        ^
utils/utils.go:615:33: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
                replaced = strings.ReplaceAll(fmt.Sprintf("%s",
                                              ^
utils/utils.go:618:33: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
                replaced = strings.ReplaceAll(fmt.Sprintf("%s",
                                              ^
utils/utils.go:576:21: SA6000: calling regexp.MatchString in a loop has poor performance, consider using regexp.Compile (staticcheck)                pathCharExp, _ := regexp.MatchString("[%=;~.]", segs[i])
                                  ^

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1d566cd) 99.75% compared to head (84c9447) 99.75%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files         149      149              
  Lines       10822    10821       -1     
==========================================
- Hits        10796    10794       -2     
- Misses         26       27       +1     

Flag	Coverage Δ
unittests	99.75% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
utils/utils.go	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nickajacks1]

Hmmm why did coverage go down on an unrelated file? I'll take a look later...

[daveshanley]

Nice! yeah all these regexes should always be pre-compiled, I must have been rushing.

[daveshanley]

LGTM.

[daveshanley]

I ignore any off by one code coverage results 0.01% is a rounding error in coverage and not a concern of mine.