Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for the speakeasy iteration use case #189

Conversation

TristanSpeakEasy
Copy link
Contributor

This should help catch any future regressions that will impede the iteration of a spec as done in one of Speakeasy's use cases

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fb4865) 99.78% compared to head (253fb83) 99.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   99.78%   99.80%   +0.01%     
==========================================
  Files         155      155              
  Lines       11725    11725              
==========================================
+ Hits        11700    11702       +2     
+ Misses         25       23       -2     
Flag Coverage Δ
unittests 99.80% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TristanSpeakEasy
Copy link
Contributor Author

ready to merge @daveshanley

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

@daveshanley daveshanley merged commit d9c36c2 into pb33f:main Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants