-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce ordered maps into libopenapi #205
Conversation
…ize parallel processing of slices and channels in stable order.
Fix goroutine resource leak in `datamodel/low/v3/path_item.go`.
…ator. Integrate `TranslateMapParallel()` into datamodel for `Paths` to replace specialized async logic.
Integrate `TranslatePipeline()` into datamodel for schema components to replace specialized async logic.
Revert change to `Scopes` back to `map` type. `orderedmap.Map` is not properly marshaling this one field from YAML.
… map. Improve test coverage.
Let me know when you're ready for me to review. |
It is ready to review now we have had it in production for the last couple
of days and no issues yet
…On Tue, 12 Dec 2023 at 18:36, quobix ***@***.***> wrote:
Let me know when you're ready for me to review.
—
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZYQK2GLFN3KXSJXEEIZCO3YJCPZFAVCNFSM6AAAAAA74L3OGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGU4TSNRWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I am working my way through it, should be done tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, what a PR! Such a huge lift to turn this around, but provides a real maturity to the library, allowing us to march forward with other higher level features, knowing the lower levels are now solid.
In regards to coverage, I would really appreciate bringing it up to 99.6 at a minimum. I don't want to lose the |
I'll try and achieve this, some of the uncovered lines were a bit hard to determine the best way to test but I'll try a few techniques and then reach out for help if needed |
Okay coverage seems to be at 99.60% now so hopefully good to go? @daveshanley |
I have pull requests ready to go in libopenapi-validator and vacuum once this merges and I can update those dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think you need to rebase however, there are conflicts.
Picks up from #138 and tries to address #119
The main goals will be:
Done: