New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add classes for cooling sensors #1284

Draft

nrwslac wants to merge 1 commit into pcdshub:master from nrwslac:tmo-flow-update

Contributor

nrwslac commented Sep 13, 2024

Description

added PhotonCollimatorFDQ to pc.py
added BeckhoffPneumaticFDQ to pneumatic.py
add an instance of FDQ to TMOSpectrometer - happi prefix here was TMO:SPEC, so ended up making a pull request in tmo-motion to change the PV name: ENH: tmo spectrometer uses TMO:SPEC as happi prefix lcls-plc-tmo-motion#132

Motivation and Context

installed flow meters in TMO for ST4K4, SP1K4, and PC5K4.

How Has This Been Tested?

I loaded local typhos screens, found one discrepancy. that will work itself out in next tmo-motion maintenance.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-5568

Pre-merge checklist

Code works interactively
Code contains descriptive docstrings, including context and API
New/changed functions and methods are covered in the test suite where possible
Test suite passes locally
Test suite passes on GitHub Actions
Ran docs/pre-release-notes.sh and created a pre-release documentation page
Pre-release docs include context, functional descriptions, and contributors as appropriate


          ENH: add classes for cooling sensors

1265aa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet