FIX: SmarPod detailed ui needs correct name to be picked up by typhos #1291
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
previously approved these changes
Oct 4, 2024
docs/source/upcoming_release_notes/1291-fix_smarpod_ui_name.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Tang-Kong <[email protected]>
tangkong
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring a
dev_condahotfix into prod:Motivation and Context
I'm going through all open dev edits that have value and trying to get them merged back into prod.
This one was implemented a while back and should be considered stable.
https://jira.slac.stanford.edu/browse/ECS-6333
How Has This Been Tested?
Interactively via usage since being introduced to dev
Where Has This Been Documented?
I will make a pre-release notes page before requesting reviews
Pre-merge checklist
Code contains descriptive docstrings, including context and APINew/changed functions and methods are covered in the test suite where possible