ENH: New devices

[ZryletTC]

Description

Creates new classes for goniometers, von Hamos spectrometers, Beckhoff liquid jets, TimeTools, and PFLSes. Adds CombinedInOutRecordPositioner for use with X/Y combined state devices.
Also included minor other fixes.

Motivation and Context

Need support for these devices in new python.
Also fixes #384.

How Has This Been Tested?

Created tests for new devices. All tests pass.

Where Has This Been Documented?

Added docstrings. Their style will be fixed in upcoming PR.

[codecov-io]

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          40       40           
  Lines        3561     3561           
=======================================
  Hits         3341     3341           
  Misses        220      220           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba6ccd...5ba6ccd. Read the comment docs.

[ZryletTC]

Merged in pre-commit changes.

[ZryletTC]

I decided to make the docstring style consistent in the rest of the repo so I'll add that as a separate PR because there a lot of changes. Style changes for these files will be included there.

[ZryletTC]

Docs aren't building, please don't merge until fixed.

• Could be fixed by m2r#55
• If desired, can be bypassed for now by pinning sphinx<3.0.0 or specifying the hotfix branch of m2r
• Realistically, that PR will never be merged as the repo has been inactive since 2018 so a better course of action would probably be to drop m2r and switch to recommonmark as others are

[ZLLentz]

You don't have to fix the docs in this PR, we can do that in a separate PR.

[ZryletTC]

Doc build fix merged in.

[ZLLentz]

I don't have much to add. Thanks for fixing all the side things you spotted while making this PR. Make sure you change the title of this PR to something other than WIP before we merge.

[silkenelson]

I think the XCS goniometer is now missing its XYZ motors. As they are not in base anymore, the "withArm" goniometer needs an XYZ stage object attached to it.

I couldn't figure out how to reply below this....
From staring at setup photos that Rajan sent to me, it looks one can remove the XYZ to fit vacuum chambers. So leave the code as it is and we see how to create the XYZ if it exists for XCS later.

[ZryletTC]

I think the XCS goniometer is now missing its XYZ motors. As they are not in base anymore, the "withArm" goniometer needs an XYZ stage object attached to it.

@silkenelson, is the XYZ stage not removable in XCS? If it is, I'll add them in my implementation of #418.
If not, I can add an inheritance now.

[ZryletTC]

Raj showed me a time when the XYZ stage was removed for an experiment so I will add them as with #418.

[klauer]

🎉