Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #1177: add a <a> element on page title to support link to home #1178

Closed
wants to merge 1 commit into from

Conversation

parmentelat
Copy link

hey

as a first step towards #1177 I had been playing with this approach
rationale being the home icon in the header, which at first I had taken as a hint towards going back to home page

I could maybe also add a shortcut as per your suggestion but I do not yet feel comfortable messing about in this area

let me know what you think

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
🔨 Latest commit 7863da5
🔍 Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/66efefe85a61e90008cdbfa5
😎 Deploy Preview https://deploy-preview-1178--xenodochial-hugle-b9ec84.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pcottle
Copy link
Owner

pcottle commented Sep 22, 2024

Ah interesting, just pulled this down locally to play with it:
Screenshot 2024-09-22 at 5 39 22 PM

It's a good start! But I think my hesitation is that:

  • its not super clear why the header is blue now
  • clicking it will immediately clear your local state, possibly wiping out any progress you might have!

so I worry about people accidentally clicking it. It's also a bit of an odd visual design paradigm to have a link thats not underlined.

Its super easy to add another icon in that bottom bar. Just edit this file and add a new entry:

Use the icon classname here:
https://fontawesome.com/icons/broom?f=classic&s=solid

and then execute something like this to perform the reset:

text: intl.str('command-helper-bar-reset'),
onClick: function() {
this.fireCommand('reset');
}.bind(this),

@pcottle pcottle closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants