Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor map creation functions #17

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Refactor map creation functions #17

merged 3 commits into from
Feb 4, 2024

Conversation

pdil
Copy link
Owner

@pdil pdil commented Feb 4, 2024

  • Created alaska_bbox(), hawaii_bbox(), alaska_transform(), and hawaii_transform() internal functions.
    • These are intended to be used by usmap::usmap_transform() for consistency.
  • Removed as_sf deprecation warnings since this change is intended to be an implementation detail from the perspective of usmap.
    • i.e. warnings should not be seen by usmap users for decisions made within this package they have little control over

@pdil pdil added the tech Technical issues and pull requests not directly related to usmapdata functionality label Feb 4, 2024
@pdil pdil self-assigned this Feb 4, 2024
@pdil pdil marked this pull request as ready for review February 4, 2024 03:48
@pdil pdil merged commit aee0d4b into master Feb 4, 2024
8 checks passed
@pdil pdil deleted the feature/refactor-map-creation branch February 4, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmapdata functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pdil