correct default value for resolve_max_rounds in documentation #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
approved these changes
Oct 30, 2022
|
CI failure looks unrelated to anything I've done. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
news/describing what is new.Test cases added for changed code.Describe what you have changed in this PR.
Went looking for the exact value due to the question in Discord regarding very high lock rounds. Noticed that the docs say that the default value is 1000, but the config item is set to 10000.
pdm/docs/docs/usage/configuration.md
Line 56 in 1e5dc62
pdm/src/pdm/project/config.py
Lines 161 to 166 in 8ef9276