Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the log leakage in installation #1689

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix: Fix the log leakage in installation #1689

merged 2 commits into from
Feb 8, 2023

Conversation

frostming
Copy link
Collaborator

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix #1635

@frostming frostming changed the base branch from main to dev February 8, 2023 11:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 85.13% // Head: 85.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f91a7b7) compared to base (ae911d4).
Patch coverage: 90.47% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1689      +/-   ##
==========================================
+ Coverage   85.13%   85.14%   +0.01%     
==========================================
  Files          92       92              
  Lines        8618     8624       +6     
  Branches     1866     1868       +2     
==========================================
+ Hits         7337     7343       +6     
  Misses        864      864              
  Partials      417      417              
Flag Coverage Δ
unittests 84.96% <90.47%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/synchronizers.py 82.87% <87.50%> (+0.33%) ⬆️
src/pdm/cli/actions.py 77.75% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 37416af into dev Feb 8, 2023
@frostming frostming deleted the fix/install-log branch February 8, 2023 11:10
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm install prints errors for missing build dependencies in extra pypi indexes when using dynamic versioning
2 participants