Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consider packages installed if the venv includes them from the system-site #2219

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2216

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 77.19% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
src/pdm/installers/synchronizers.py 66.66%
src/pdm/models/venv.py 72.41%
src/pdm/environments/python.py 77.77%
src/pdm/models/working_set.py 90.90%
src/pdm/pytest.py 100.00%

📢 Thoughts on this report? Let us know!.

@frostming frostming merged commit 63423b2 into main Aug 31, 2023
18 checks passed
@frostming frostming deleted the frostming/issue2216 branch August 31, 2023 07:39
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider packages installed if the venv includes them from the system-site
2 participants