Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check list for empty build error output #2346

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

xzmeng
Copy link
Contributor

@xzmeng xzmeng commented Oct 29, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

fixes #2337

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/pdm/builders/base.py 89.20% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@frostming
Copy link
Collaborator

Thank you, this PR is also qualified as valid for Hacktoberfest, if you need it.

@frostming frostming merged commit 6f87c5a into pdm-project:main Oct 30, 2023
24 checks passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty build error not correctly parsed
3 participants