add support for {pdm} placeholder in scripts
#2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
==========================================
+ Coverage 84.51% 84.53% +0.02%
==========================================
Files 102 103 +1
Lines 10109 10129 +20
Branches 2224 2226 +2
==========================================
+ Hits 8544 8563 +19
- Misses 1087 1088 +1
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hmm, will have to look at Windows failures tomorrow. I'm going to guess related to path normalization in some way... |
frostming
reviewed
Nov 16, 2023
frostming
reviewed
Nov 16, 2023
frostming
pushed a commit
that referenced
this pull request
Nov 23, 2023
* add support for `{pdm}` placeholder in scripts
* check should_interpolate
* fix docs
* add news item
* Fix feedback and Windows
frostming
pushed a commit
that referenced
this pull request
Dec 1, 2023
* add support for `{pdm}` placeholder in scripts
* check should_interpolate
* fix docs
* add news item
* Fix feedback and Windows
frostming
pushed a commit
that referenced
this pull request
Dec 1, 2023
* add support for `{pdm}` placeholder in scripts
* check should_interpolate
* fix docs
* add news item
* Fix feedback and Windows
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
As discussed on Discord, this adds support for using a
{pdm}placeholder in scripts to refer to the current interpreter. I'm not sure if this should affect calls in any way, but I don't think so since they'd (presumably) use the same python interpreter/venv.