Fix #2183 no timeout for PyPI calls #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 84.68% 84.69%
=======================================
Files 104 104
Lines 10279 10282 +3
Branches 2234 2234
=======================================
+ Hits 8705 8708 +3
Misses 1102 1102
Partials 472 472
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostming
requested changes
Feb 29, 2024
frostming
approved these changes
Mar 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what you have changed in this PR.
Updated unearth dependency to version 0.14.0 to prevent pdm from hanging indefinitely when pypi.org is resolved but all other packets (i.e. non-DNS packets) are dropped.
After investigation of issue #2183, we found that the problem was caused by the unearth package. However, it was solved in v. 0.14.0, specifically in commit 1d9a2dc. Therefore, this PR simply updates the unearth dependency to version 0.14.0.
Closes #2183