Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout config for network requests #2683

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Fixes #2680

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (15c9600) to head (cbdf431).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files         104      104           
  Lines       10293    10295    +2     
  Branches     2235     2236    +1     
=======================================
+ Hits         8733     8735    +2     
  Misses       1099     1099           
  Partials      461      461           
Flag Coverage Δ
unittests 84.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit f251940 into main Mar 13, 2024
21 checks passed
@frostming frostming deleted the frostming/issue2680 branch March 13, 2024 00:53
@frostming frostming restored the frostming/issue2680 branch March 13, 2024 01:48
@frostming frostming deleted the frostming/issue2680 branch March 13, 2024 01:48
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout fail with "large" libraries
1 participant