Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable colors in pdm help on legacy terminals of windows #2684

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

frostming
Copy link
Collaborator

Close #2678

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (9e712c2) to head (c1e74a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
- Coverage   84.78%   84.75%   -0.03%     
==========================================
  Files         104      104              
  Lines       10300    10300              
  Branches     2239     2239              
==========================================
- Hits         8733     8730       -3     
- Misses       1103     1106       +3     
  Partials      464      464              
Flag Coverage Δ
unittests 84.54% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming changed the title fix: color system issue on windows fix: disable colors in pdm help on legacy terminals of windows Mar 13, 2024
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit 46d0064 into main Mar 13, 2024
20 of 21 checks passed
@frostming frostming deleted the fix/windows-color branch March 13, 2024 03:10
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pdm help information encountered abnormal characters on Windows.
1 participant