Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring log file directory #2687

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Mar 13, 2024

Fixes #2398
Closes #2518

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (46d0064) to head (6ebaec9).

Files Patch % Lines
src/pdm/core.py 81.57% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
+ Coverage   84.75%   84.80%   +0.04%     
==========================================
  Files         104      104              
  Lines       10300    10307       +7     
  Branches     2239     2238       -1     
==========================================
+ Hits         8730     8741      +11     
+ Misses       1106     1102       -4     
  Partials      464      464              
Flag Coverage Δ
unittests 84.59% <89.06%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 1d370a3 into main Mar 13, 2024
21 checks passed
@frostming frostming deleted the frostming/issue2398 branch March 13, 2024 08:15
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring log file directory
1 participant