Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap 'nosh_usrs' user names in word boundaries #374

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jahatfi
Copy link

@jahatfi jahatfi commented Jul 25, 2023

This is to prevent false positives when such names are substrings of other strings:
Before
2023-07-24_19-46
After:
2023-07-24_19-52

…ives when such names are substrings of other strings
@github-actions
Copy link

File: linPEAS/builder/linpeas_parts/linpeas_base.sh

  1. Line 452-455: Security Issue / Code Smell

    • The script is reading the /etc/passwd file which contains sensitive user information. Although it's a common practice in Unix-like systems, it's important to ensure that this script is run with appropriate permissions and the output is handled securely.
    • The use of grep, cut, tr, sed, and awk in a pipeline can be inefficient and hard to maintain. Consider using a single awk command to achieve the same result. This would improve the performance and readability of the code.
  2. Line 455: Code Bug

    • The awk command is used before sort and cut which could lead to incorrect results. The awk command should be used after cut to ensure it's applied to the correct field.
  3. Line 455: Code Smell

    • The use of a magic string "ImPoSSssSiBlEee" can lead to potential issues if this string somehow becomes a valid username. Consider using a more unique string or a different approach to mark the end of the list.
  4. General: Security Issue

    • There is no evidence of input validation or error handling in this script. It's important to validate any input and handle errors appropriately to prevent potential security issues and crashes.

@carlospolop carlospolop merged commit 0ab20b9 into peass-ng:master Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants