Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainly add support for children URLS + minor changes #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mainly add support for children URLS + minor changes #8

wants to merge 3 commits into from

Conversation

julien-gargot
Copy link

  • I added a support for children URLS in sitemap.ignored.pages using /* at this end of an uri.
    For example:
    c::set('sitemap.ignored.pages', ['page-to-exclude', 'page-to-exclude/*']);
    
  • CSS are now hosted in local.
  • I removed the footer because I do not like signatures. But it is a very personal opinion, just do not consider this part of the pull request ;)

@pedroborges
Copy link
Owner

Hi @julien-gargot! Thank you for working on this pull request. I'll be rewriting the plugin before the end of the year as I want to add one feature that requires a different structure.

I really like the suggestion to include the CSS locally. That will be the default for sure!

I'll keep the footer, anyone who is not comfortable can easily remove it anyway.

Regarding the wildcard on the sitemap.ignored.pages option, I'm willing to add that but I'd like to better understand your use case. Are you aware of the sitemap.ignored.templates option? Most of the time, children of a page use the same the same template, like products and product, for example. Let's discuss this 😉

@julien-gargot
Copy link
Author

Thank you to take time to review what I did. It’s a good news if you still work on improving the plugin!

Regarding the wildcard on the sitemap.ignored.pages option, I'm willing to add that but I'd like to better understand your use case. Are you aware of the sitemap.ignored.templates option? Most of the time, children of a page use the same the same template, like products and product, for example. Let's discuss this 😉

Yes! Your tottally right, I didn’t think about that and I could have use it! I just have few templates under the level I wanted to exclude… Maybe it’s just due to a habit of mine to use expressions like that in command lines :)

Anyway, do not hesitate to message me if you need extra point of view or hands.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants