Fix @ character in path portion

#13
peerigon · Feb 7, 2017 · 1f2475e · 1f2475e
1 parent a27a2c8
commit 1f2475e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/parseDomain.js b/lib/parseDomain.js
@@ -1,6 +1,6 @@
 "use strict";
 
-var urlParts = /^(https?:\/\/)?(.+@)?(.+?)(:\d{2,5})?([/?].*)?$/; // 1 = protocol, 2 = auth, 3 = domain, 4 = port, 5 = path
+var urlParts = /^(https?:\/\/)?([^/]*@)?(.+?)(:\d{2,5})?([/?].*)?$/; // 1 = protocol, 2 = auth, 3 = domain, 4 = port, 5 = path
 var knownTlds = require("./tld.js");
 var dot = /\./g;
 

diff --git a/test/parseDomain.test.js b/test/parseDomain.test.js
@@ -71,6 +71,14 @@ describe("parseDomain(url)", function () {
         });
     });
 
+    it("should allow @ characters in the path", function () {
+        expect(parseDomain("https://medium.com/@username/")).to.eql({
+            subdomain: "",
+            domain: "medium",
+            tld: "com"
+        });
+    });
+
     it("should also work with three-level domains like .co.uk", function () {
         expect(parseDomain("www.example.co.uk")).to.eql({
             subdomain: "www",
@@ -87,7 +95,7 @@ describe("parseDomain(url)", function () {
         });
     });
 
-    it("should include private tlds ", function () {
+    it("should include private tlds", function () {
         expect(parseDomain("foo.blogspot.com", { privateTlds: true })).to.eql({
             subdomain: "",
             domain: "foo",