Skip to content

Commit

Permalink
[Conductor] Update post submit location (#106120)
Browse files Browse the repository at this point in the history
* readability refactor

* update post-submits

Update post submit testing status location from LUCI to cocoon.  Conductor users will still have to use navigation to pick the correct repository and release candidate to monitor.
  • Loading branch information
itsjustkevin authored Jun 16, 2022
1 parent 995b332 commit 9e67070
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 12 deletions.
46 changes: 37 additions & 9 deletions dev/conductor/core/lib/src/globals.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,36 @@ const String kForceFlag = 'force';

const List<String> kBaseReleaseChannels = <String>['stable', 'beta'];

const List<String> kReleaseChannels = <String>[...kBaseReleaseChannels, FrameworkRepository.defaultBranch];
const List<String> kReleaseChannels = <String>[
...kBaseReleaseChannels,
FrameworkRepository.defaultBranch
];

const String kReleaseDocumentationUrl = 'https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process';
const String kReleaseDocumentationUrl =
'https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process';

const String kLuciPackagingConsoleLink = 'https://ci.chromium.org/p/flutter/g/packaging/console';
const String kLuciPackagingConsoleLink =
'https://ci.chromium.org/p/flutter/g/packaging/console';

const String kWebsiteReleasesUrl = 'https://docs.flutter.dev/development/tools/sdk/releases';
const String kWebsiteReleasesUrl =
'https://docs.flutter.dev/development/tools/sdk/releases';

const String discordReleaseChannel =
'https://discord.com/channels/608014603317936148/783492179922124850';

const String flutterReleaseHotline =
'https://mail.google.com/chat/u/0/#chat/space/AAAA6RKcK2k';

const String hotfixToStableWiki =
'https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel';

const String flutterAnnounceGroup =
'https://groups.google.com/g/flutter-announce';

const String hotfixDocumentationBestPractices =
'https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices';

const String cocoonDashboard = 'https://flutter-dashboard.appspot.com/#/build';

const String discordReleaseChannel =
'https://discord.com/channels/608014603317936148/783492179922124850';
Expand Down Expand Up @@ -96,7 +119,8 @@ String? getValueFromEnvOrArgs(
if (allowNull) {
return null;
}
throw ConductorException('Expected either the CLI arg --$name or the environment variable $envName '
throw ConductorException(
'Expected either the CLI arg --$name or the environment variable $envName '
'to be provided!');
}

Expand Down Expand Up @@ -135,7 +159,8 @@ List<String> getValuesFromEnvOrArgs(
return argValues;
}

throw ConductorException('Expected either the CLI arg --$name or the environment variable $envName '
throw ConductorException(
'Expected either the CLI arg --$name or the environment variable $envName '
'to be provided!');
}

Expand Down Expand Up @@ -171,7 +196,8 @@ String getNewPrLink({
repoLabel = 'Engine';
break;
default:
throw ConductorException('Expected repoName to be one of flutter or engine but got $repoName.');
throw ConductorException(
'Expected repoName to be one of flutter or engine but got $repoName.');
}
assert(candidateBranch.isNotEmpty);
assert(workingBranch.isNotEmpty);
Expand All @@ -188,12 +214,14 @@ String getNewPrLink({
if (state.engine.dartRevision.isNotEmpty) {
// shorten hashes to make final link manageable
// prefix with github org/repo so GitHub will auto-generate a hyperlink
body.writeln('- Roll dart revision: dart-lang/sdk@${state.engine.dartRevision.substring(0, 9)}');
body.writeln(
'- Roll dart revision: dart-lang/sdk@${state.engine.dartRevision.substring(0, 9)}');
}
for (final pb.Cherrypick cp in state.engine.cherrypicks) {
// Only list commits that map to a commit that exists upstream.
if (cp.trunkRevision.isNotEmpty) {
body.writeln('- commit: flutter/engine@${cp.trunkRevision.substring(0, 9)}');
body.writeln(
'- commit: flutter/engine@${cp.trunkRevision.substring(0, 9)}');
}
}
} else {
Expand Down
5 changes: 2 additions & 3 deletions dev/conductor/core/lib/src/state.dart
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ String presentState(pb.ConductorState state) {
buffer.writeln('\tCurrent git HEAD: ${state.engine.currentGitHead}');
buffer.writeln('\tPath to checkout: ${state.engine.checkoutPath}');
buffer.writeln(
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'engine')}');
'\tPost-submit cocoon dashboard: ${globals.cocoonDashboard}');
if (state.engine.cherrypicks.isNotEmpty) {
buffer.writeln('${state.engine.cherrypicks.length} Engine Cherrypicks:');
for (final pb.Cherrypick cherrypick in state.engine.cherrypicks) {
Expand All @@ -95,8 +95,7 @@ String presentState(pb.ConductorState state) {
buffer.writeln('\tStarting git HEAD: ${state.framework.startingGitHead}');
buffer.writeln('\tCurrent git HEAD: ${state.framework.currentGitHead}');
buffer.writeln('\tPath to checkout: ${state.framework.checkoutPath}');
buffer.writeln(
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'flutter')}');
buffer.writeln('\tPost-submit cocoon dashboard: ${globals.cocoonDashboard}');
if (state.framework.cherrypicks.isNotEmpty) {
buffer.writeln(
'${state.framework.cherrypicks.length} Framework Cherrypicks:');
Expand Down

0 comments on commit 9e67070

Please sign in to comment.