Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document imported via IIIF not displaying properly #570

Closed
mromanello opened this issue Oct 17, 2018 · 7 comments
Closed

Document imported via IIIF not displaying properly #570

mromanello opened this issue Oct 17, 2018 · 7 comments
Assignees

Comments

@mromanello
Copy link

Hi @rsimon

As I mentioned, I'm running into some issues when importing a manuscript from e-codices (https://www.e-codices.unifr.ch/en/list/one/bge/gr0044) into Recogito (fwiw the document is https://recogito.pelagios.org/document/mtxabgqcgnbxj9/part/1/edit).

The first couple of pages display OK, but the others don't (although when fiddling a bit with zoom levels something eventually shows up). I attach some screenshots.

Hope it helps to track the issue down!

image

image

@rsimon
Copy link
Member

rsimon commented Oct 17, 2018

Hi @mromanello,

thanks for this. This is (somewhat of) a know issue, but I now realize there was not yet a ticket for it. There's a bug with the view layer that we've been trying to fix for a while. But we haven't fully nailed it down yet. It's definitely related to the computation of the pyramid levels/resolutions from the canvas size reported in the manifest, and happens under (yet to be completely identified...) certain circumstances where (in addition to those circumstances...) the image dimensions are not an exact multiple of the tile size (which is usually the case). At least that's my current understanding (or lack thereof :-) of the problem.

We've been through a round of discussions about this (but also other related issues) here. But nothing final yet. FWIW, our code where the X/Y/Z values get derived from the image dimensions is here:

https://github.com/pelagios/recogito2/blob/master/app/assets/javascripts/document/annotation/image/iiif/iiifSource.js#L89-L129

Input from anyone who's knowledgeable in the IIIF Image API is greatly, crucially and gratefully appreciated! I also tried to cross-check with (and port from) the corresponding code bits in OpenSeadragon at some point (see here), but then ran out of time. (And their code is also organized a little different.)

@rsimon rsimon added the ready label Oct 18, 2018
@lutzhelm
Copy link

I ran into the same (underlying) issue. Please have a look at my thoughts on that in kitodo/kitodo-presentation#306 and the proposed solution in klokantech/iiifviewer#25.

@regisrob
Copy link

regisrob commented Nov 19, 2018

FWIW (as it seems to be the same display issue), here is another IIIF image imported into Recogito for testing and that has the same bug (at least apparently): https://recogito.pelagios.org/document/gueq5n9p0rci6t

@rsimon
Copy link
Member

rsimon commented Nov 20, 2018

Hi @regisrob, thanks for this - yes it's the exact same issue.

@lutzhelm: fantastic, many thanks for letting me know. Indeed this looks like what's happening. I'll try to fix along the same lines.

@rsimon rsimon added in progress and removed ready labels Dec 17, 2018
@rsimon rsimon self-assigned this Dec 17, 2018
rsimon pushed a commit that referenced this issue Dec 17, 2018
@rsimon
Copy link
Member

rsimon commented Dec 17, 2018

Dear all, I just ported the fix from @lutzhelm over to Recogito - and it seems to have done the trick perfectly. Many many thanks for this!

@lutzhelm
Copy link

FYI, my pull request to OpenLayers that introduces a built-in IIIF Image API tile source has just been accepted: openlayers/openlayers#9430
Should you ever consider moving to OpenLayers 6 once it is released, IIIF will already be there...

@rsimon
Copy link
Member

rsimon commented May 13, 2019

I saw that - fantastic. Many thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants