Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output_mapping.js appears to print incomplete schema #161

Closed
easherma opened this issue Aug 3, 2016 · 2 comments · Fixed by #162
Closed

output_mapping.js appears to print incomplete schema #161

easherma opened this issue Aug 3, 2016 · 2 comments · Fixed by #162
Assignees
@orangejulius

Comments

@easherma
Copy link

easherma commented Aug 3, 2016

I've tried running the script and viewing the results in terminal as well as writing them to a file. In both cases, the output appears cut-off (though at different points in the expected output, depending on if I'm looking at the printed output vs writing stdout to a file: https://gist.github.com/easherma/b4f878f9ee67f9036f687890f16444f1
@easherma
Copy link
Author

easherma commented Aug 3, 2016

Additionally, expected.json doesn't appear to match what the current schema should look like (according to a gist @orangejulius sent me today)

orangejulius added a commit that referenced this issue Aug 4, 2016
@orangejulius
Rearrange logic in output_mapping
db3ce4a 
`process.exit` can truncate long output in certain node versions, see
these tickets:

nodejs/node#3669
nodejs/node#3170
nodejs/node#2972 (comment)

fixes #161
@orangejulius orangejulius mentioned this issue Aug 4, 2016
Merged
@orangejulius orangejulius self-assigned this Aug 4, 2016
@orangejulius
Copy link
Member

orangejulius commented Aug 4, 2016 •
edited
Loading

Ahh, good catch, its the ol' process.exit issue with lots of data going through console.log. Fixed in #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orangejulius orangejulius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rearrange logic in output_mapping pelias/schema
2 participants
@orangejulius @easherma