deps: update histogram, metriken, and ringlog #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies to move towards a single version of histogram (0.11.0) and metriken (0.7.0). This is a breaking change in the interface of calls to percentile functions, which can now return null when the histogram is empty. The metrics functions call the percentiles and publish them using an iterator over them. Rather than changing the interface of the wrapper function to returning null when the histogram is empty, it returns an empty vector to metrics callers, which prevents them from publishing percentile metrics.
brayniac
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies to move towards a single version
of histogram (0.11.0) and metriken (0.7.0). This is
a breaking change in the interface of calls to percentile
functions, which can now return null when the histogram
is empty.
The metrics functions call the percentiles and publish
them using an iterator over them. Rather than changing
the interface of the wrapper function to returning null
when the histogram is empty, it returns an empty vector
to metrics callers, which prevents them from publishing
percentile metrics.