Adds DeepReadonly #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelotom
requested changes
May 8, 2018
| foo.bam.push({ bap: [] }); | ||
|
|
||
| // $ExpectError | ||
| foo.bab.bab.bab = "hi"; |
There was a problem hiding this comment.
It would be good to have some $ExpectTypes as well, to establish the positive properties of this operator.
types/index.d.ts
Outdated
| /** | ||
| * Creates a type that only includes the properties which are functions in T. | ||
| */ | ||
| export type NonFunctionProperties<T> = Pick<T, NonFunctionPropertyNames<T>>; |
There was a problem hiding this comment.
These don't seem to me to be of general enough utility to define them as top-level exports. I would get rid of FunctionPropertyNames/FunctionProperties since they aren't needed in the definition of DeepReadonly, and inline NonFunctionPropertyNames/NonFunctionProperties.
pelotom
requested changes
May 8, 2018
types/index.d.ts
Outdated
| export type DeepReadonlyObject<T> = { | ||
| readonly [P in NonFunctionPropertyNames<T>]: DeepReadonly<T[P]>; | ||
| // tslint:disable-next-line: semicolon strict-export-declare-modifiers ban-types | ||
| readonly [P in { [K in keyof T]: T[K] extends Function ? never : K; }[keyof T]]: DeepReadonly<T[P]>; |
There was a problem hiding this comment.
I would inline DeepReadonlyArray and DeepReadonlyObject as well.
Also the build is failing currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourced from microsoft/TypeScript#21316